Fix UTMP misinterpretation of IPv6 addresses

[Zawadidone]

Closes #291

[Zawadidone]

What is the best place for this code? So that the code can be re-used by the BTMP parser.

[Schamper]

What is the best place for this code? So that the code can be re-used by the BTMP parser.

Perhaps here, and yield some named tuples with this pre-parsed field instead of the direct cstruct entry? https://github.com/fox-it/dissect.target/blob/main/dissect/target/plugins/os/unix/log/utmp.py

[Zawadidone]

@cecinestpasunepipe should the files wtmp.py and btmp.py be combined in utmp.py with the namespace utmp with the functiosn wtmp and btmp? Because the code is identical and only the path and record name is different.

[Schamper]

@cecinestpasunepipe should the files wtmp.py and btmp.py be combined in utmp.py with the namespace utmp with the functiosn wtmp and btmp? Because the code is identical and only the path and record name is different.

You could also just put a UtmpPlugin in utmp.py with a function btmp and wtmp, skipping the namespace.

[Zawadidone]

Okay I have combined the functions

[Zawadidone]

@cecinestpasunepipe can you take look at this PR?

[cecinestpasunepipe]

Okay I have combined the functions

Yes, I will review this PR right now.

[codecov]

Codecov Report

Merging #292 (a9261f8) into main (f895370) will increase coverage by 0.02%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.02%     
==========================================
  Files         238      236       -2     
  Lines       18717    18725       +8     
==========================================
+ Hits        13452    13463      +11     
+ Misses       5265     5262       -3     

Flag	Coverage Δ
unittests	71.89% <96.66%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
dissect/target/plugins/os/unix/log/utmp.py	94.59% <96.66%> (+4.59%)	⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[cecinestpasunepipe]

LGTM

[Zawadidone]

@pyrco @cecinestpasunepipe thank you for reviewing the PR and coming with suggestions to fix the problem.