Improve tar loader for windows #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Aug 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 71.77% 71.78%
=======================================
Files 238 238
Lines 18702 18704 +2
=======================================
+ Hits 13424 13427 +3
+ Misses 5278 5277 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Schamper
previously approved these changes
Aug 21, 2023
Schamper
reviewed
Aug 21, 2023
Schamper
approved these changes
Aug 21, 2023
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improved support for relative and absolute tar member name paths when dealing with windows tar filesystems.
In the future we'd like to replace this
mapfunction with the mapping functionality ofTarFilesystem. For now this is a quick fix to improve tar loader detection on our end.