-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Citrix _os.py for correct timezone detection #363
Update Citrix _os.py for correct timezone detection #363
Conversation
Fix a crash when fetching the timezone of the netscaler when it has a configline like 'set ns param -cookieversion 1 -timezone "GMT+02:00-CEST-Europe/Amsterdam"'.
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 71.75% 71.75%
=======================================
Files 238 238
Lines 18684 18684
=======================================
Hits 13406 13406
Misses 5278 5278
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@RGlintmeijer thank you for your contribution! As this is your first code contribution, please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following information:
Contributor License Agreement
Contribution License AgreementThis Contribution License Agreement ("Agreement") governs your Contribution(s) (as defined below) and conveys certain license rights to Fox-IT B.V. ("Fox-IT") for your Contribution(s) to Fox-IT"s open source Dissect project. This Agreement covers any and all Contributions that you ("You" or "Your"), now or in the future, Submit (as defined below) to this project. This Agreement is between Fox-IT B.V. and You and takes effect when you click an “I Accept” button, check box presented with these terms, otherwise accept these terms or, if earlier, when You Submit a Contribution.
|
@DissectBot agree |
Fix a crash when fetching the timezone of the netscaler when it has a configline like 'set ns param -cookieversion 1 -timezone "GMT+02:00-CEST-Europe/Amsterdam"'.