Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on empty or missing RegBack hives #388

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Don't warn on empty or missing RegBack hives #388

merged 6 commits into from
Sep 11, 2023

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Sep 8, 2023

No description provided.

@Schamper Schamper requested a review from Poeloe September 8, 2023 08:09
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #388 (8d271ee) into main (43d0b02) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   72.45%   72.49%   +0.03%     
==========================================
  Files         239      239              
  Lines       19047    19051       +4     
==========================================
+ Hits        13801    13811      +10     
+ Misses       5246     5240       -6     
Flag Coverage Δ
unittests 72.49% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/plugins/os/windows/registry.py 82.15% <100.00%> (+2.25%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Poeloe Poeloe self-requested a review September 11, 2023 09:50
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schamper Schamper merged commit f9856bb into main Sep 11, 2023
18 checks passed
@Schamper Schamper deleted the warn-regback branch September 11, 2023 18:03
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants