Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source field value a posix path #391

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Sep 8, 2023

Fixes test test_plugins_os_windows_powershell within test_plugins_apps_shell_powershell on Windows.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #391 (d844af4) into main (ceee369) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   72.21%   72.21%           
=======================================
  Files         238      238           
  Lines       18993    18994    +1     
=======================================
+ Hits        13715    13716    +1     
  Misses       5278     5278           
Flag Coverage Δ
unittests 72.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/plugins/os/unix/bsd/osx/user.py 95.45% <100.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@Poeloe Poeloe force-pushed the fix/make-source-field-value-a-posix-path branch from b73bb09 to d844af4 Compare September 8, 2023 13:50
@Poeloe Poeloe merged commit c81efc0 into main Sep 9, 2023
18 checks passed
@Poeloe Poeloe deleted the fix/make-source-field-value-a-posix-path branch September 9, 2023 16:18
Poeloe added a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants