Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DefaultOS to access all plugins #398

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

cecinestpasunepipe
Copy link
Contributor

This allows for instance the log/file loader to access plugins even though the target does not have the necessary OS.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #398 (0c6bee2) into main (7a7a2fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   73.28%   73.28%           
=======================================
  Files         250      250           
  Lines       19994    19995    +1     
=======================================
+ Hits        14653    14654    +1     
  Misses       5341     5341           
Flag Coverage Δ
unittests 73.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/target/plugin.py 90.41% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco pyrco changed the title Allow DefaultOS to access namespaced plugins Allow DefaultOS to access all os plugins Sep 18, 2023
@pyrco pyrco changed the title Allow DefaultOS to access all os plugins Allow DefaultOS to access all plugins Sep 18, 2023
dissect/target/plugin.py Outdated Show resolved Hide resolved
dissect/target/plugins/general/default.py Outdated Show resolved Hide resolved
dissect/target/plugin.py Outdated Show resolved Hide resolved
pyrco
pyrco previously approved these changes Sep 20, 2023
dissect/target/plugin.py Outdated Show resolved Hide resolved
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@cecinestpasunepipe cecinestpasunepipe merged commit fb4eef4 into main Sep 22, 2023
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the feature/default_os branch September 22, 2023 11:10
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants