New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Android Backups #419
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 74.04% 74.13% +0.08%
==========================================
Files 272 259 -13
Lines 22529 20932 -1597
==========================================
- Hits 16681 15517 -1164
+ Misses 5848 5415 -433
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e7cfc09
to
41e8ca8
Compare
576cbf6
to
22c4e8d
Compare
22c4e8d
to
2244331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed something with a k
when using the followin adb flags:
adb backup -all -system -keyvalue -shared
Tho I do not know what it is for... I assume the key value information
@@ -112,8 +124,13 @@ def history(self) -> Iterator[BrowserHistoryRecord]: | |||
else: | |||
from_visit, from_place = None, None | |||
|
|||
if self.target.os == OperatingSystem.ANDROID: | |||
visit_date = from_unix_ms(row.visit_date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea to just move the check itself somewhere in the init?
something as:
class FirefoxPlugin(...):
def __init__(self, ...):
...
if self.target.os == OperatingSystem.ANDROID:
self.from_timestamp = from_unix_ms
else:
self.from_timestamp = from_unix_us
@@ -34,45 +34,57 @@ class FirefoxPlugin(BrowserPlugin): | |||
# macOS | |||
"Library/Application Support/Firefox", | |||
] | |||
|
|||
SYSTEM_DIRS = [ | |||
"/data/data/org.mozilla.vrbrowser/files/mozilla", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test this part. I wasn't able to get the information using adb.
I was able to verify it now, I did notice there is an issue in firefox.downloads(). Where the Additionally, could you add a test for the android stuff in the firefox plugin? |
Also some miscellaneous cleanup.
Depends on fox-it/dissect.util#33.
Unit tests will follow later.