Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for using the correct volume name to mount filesystems in Unix #677

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

Schamper
Copy link
Member

No description provided.

@Schamper Schamper requested a review from Poeloe April 12, 2024 11:01
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.05%. Comparing base (085e324) to head (d0523e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   74.96%   75.05%   +0.08%     
==========================================
  Files         295      295              
  Lines       25083    25084       +1     
==========================================
+ Hits        18804    18827      +23     
+ Misses       6279     6257      -22     
Flag Coverage Δ
unittests 75.05% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a small regression test?

@Schamper Schamper requested a review from Poeloe April 15, 2024 15:58
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schamper Schamper merged commit f999b3a into main Jul 12, 2024
19 of 20 checks passed
@Schamper Schamper deleted the fix-mount-volume-name branch July 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants