Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect Windows 11 builds #714

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented May 27, 2024

This PR adds correct version detection for Windows 11 systems.

This is our 100th dissect PR 🎉

Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your 100th PR!!

LGTM, jsut one small thing.

dissect/target/plugins/os/windows/_os.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.92%. Comparing base (c23a1eb) to head (f15c801).

Files Patch % Lines
dissect/target/plugins/os/windows/_os.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   74.92%   74.92%   -0.01%     
==========================================
  Files         295      295              
  Lines       25065    25070       +5     
==========================================
+ Hits        18781    18784       +3     
- Misses       6284     6286       +2     
Flag Coverage Δ
unittests 74.92% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit 4a69ca0 into fox-it:main Jun 27, 2024
17 of 18 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/windows-11-version-detection branch June 27, 2024 15:29
otnxSl pushed a commit to otnxSl/dissect.target that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants