Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ls parameters to target-fs #716

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

DevJoost
Copy link
Contributor

Add ls -ah functionality to target-fs

Mainly based it on the target-shell implementation. Also added -h (human readable) implementation that is missing in target-shell.

Resolves #626

Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, 2 very small things, but otherwise lgtm.

dissect/target/tools/fs.py Outdated Show resolved Hide resolved
dissect/target/tools/fs.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 15.15152% with 56 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (ced08e4) to head (5b80277).

Files Patch % Lines
dissect/target/tools/fs.py 15.15% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   75.37%   75.23%   -0.14%     
==========================================
  Files         296      296              
  Lines       25503    25556      +53     
==========================================
+ Hits        19223    19228       +5     
- Misses       6280     6328      +48     
Flag Coverage Δ
unittests 75.23% <15.15%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSCU-CNI JSCU-CNI mentioned this pull request Aug 1, 2024
@Schamper Schamper merged commit ec7d919 into fox-it:main Aug 1, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ls -ah functionality to target-fs
3 participants