Compatibility with cstruct v4 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 72.42% 72.35% -0.07%
==========================================
Files 26 26
Lines 1969 1957 -12
==========================================
- Hits 1426 1416 -10
+ Misses 543 541 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
force-pushed
the
cstruct-v4
branch
8 times, most recently
from
2339cb1
to
c0ab551
Compare
pyrco
requested changes
May 23, 2024
pyrco
previously approved these changes
May 24, 2024
Miauwkeru
requested changes
May 30, 2024
There was a problem hiding this comment.
Also change the definition on
dissect.volume/dissect/volume/ddf/c_ddf.py
Line 325 in d731a4c
to use
cstruct().load(...)
Miauwkeru
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30.