Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BSD disklabel #9

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Add support for BSD disklabel #9

merged 3 commits into from
Nov 11, 2022

Conversation

Schamper
Copy link
Member

No description provided.

@Schamper Schamper self-assigned this Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #9 (5df3ee7) into main (be41953) will increase coverage by 2.68%.
The diff coverage is 92.47%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   56.14%   58.82%   +2.68%     
==========================================
  Files          14       15       +1     
  Lines         871      940      +69     
==========================================
+ Hits          489      553      +64     
- Misses        382      387       +5     
Flag Coverage Δ
unittests 58.82% <92.47%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/volume/exceptions.py 100.00% <ø> (ø)
dissect/volume/disk/partition.py 64.51% <54.54%> (-2.16%) ⬇️
dissect/volume/disk/schemes/bsd.py 95.83% <95.83%> (ø)
dissect/volume/disk/disk.py 88.23% <100.00%> (+3.61%) ⬆️
dissect/volume/disk/schemes/__init__.py 100.00% <100.00%> (ø)
dissect/volume/disk/schemes/apm.py 100.00% <100.00%> (ø)
dissect/volume/disk/schemes/gpt.py 100.00% <100.00%> (ø)
dissect/volume/disk/schemes/mbr.py 75.75% <100.00%> (+0.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yunzheng yunzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work on the quick BSD support and fixes!

@Schamper Schamper merged commit f7c83bf into main Nov 11, 2022
@Schamper Schamper deleted the dis-1650_disklabel branch November 11, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants