Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reprlib to limit the warning message #101

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

yunzheng
Copy link
Member

The warning message could get very long (single line) due to extra data in msgpack parsing. For example due to corrupt file, or incorrect use.

By using reprlib we limit the length of the warning message.

The warning message could get very long (single line) due to extra data
in msgpack parsing. For example due to corrupt file, or incorrect use.

By using reprlib we limit the length of the warning message.
@yunzheng yunzheng marked this pull request as draft December 19, 2023 17:23
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (676d61c) 80.06% compared to head (d6d6069) 80.08%.

Files Patch % Lines
flow/record/stream.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   80.06%   80.08%   +0.01%     
==========================================
  Files          33       33              
  Lines        3110     3113       +3     
==========================================
+ Hits         2490     2493       +3     
  Misses        620      620              
Flag Coverage Δ
unittests 80.08% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunzheng yunzheng marked this pull request as ready for review December 19, 2023 19:14
flow/record/stream.py Show resolved Hide resolved
@yunzheng yunzheng merged commit a9808ec into main Dec 20, 2023
27 of 32 checks passed
@yunzheng yunzheng deleted the improvement/reprlib-long-warning branch December 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants