Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sed from windows test workflow #82

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

yunzheng
Copy link
Member

No description provided.

@yunzheng yunzheng requested a review from Schamper August 25, 2023 14:34
@Schamper
Copy link
Member

@pyrco IIRC this sed was only important for publishing to PyPI to get rid of the commit hashes, right? So it should be fine to remove it from these tests?

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #82 (5442cd1) into main (8a1c74f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files          32       32           
  Lines        2894     2894           
=======================================
  Hits         2291     2291           
  Misses        603      603           
Flag Coverage Δ
unittests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyrco
Copy link
Contributor

pyrco commented Aug 25, 2023

@pyrco IIRC this sed was only important for publishing to PyPI to get rid of the commit hashes, right? So it should be fine to remove it from these tests?

yes

@Schamper Schamper merged commit 6358ba3 into main Aug 25, 2023
28 checks passed
@Schamper Schamper deleted the bugfix/github-compat-workflow branch August 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants