Add Python 3.12 compatibility for path fieldtype

[yunzheng]

Fixes #89

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9808ec) 80.08% compared to head (688803a) 80.12%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   80.08%   80.12%   +0.03%     
==========================================
  Files          33       33              
  Lines        3113     3119       +6     
==========================================
+ Hits         2493     2499       +6     
  Misses        620      620              

Flag	Coverage Δ
unittests	80.12% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pyrco]

The _flavour property in 3.12 is a link to the posixpath or ntpath module. We could do something similar by having a function def custom_flavour(sep, altsep) that yields a patch()ed posixpath with the given separator and alt separator and modify PureCustomPath like:

    class PureCustomPath(pathlib.PurePath):
        if PY_312:
            _flavour = custom_flavour(sep, altsep)
        else:
            _flavour = CustomFlavour()

Our tests however just need a PurePath subclass instance with a _flavour property that has sep and altsep properties, so a simpler setup would for this case also work.

[yunzheng]

i'm happy to accept any code suggestions

[pyrco]

I'd say, just do

Suggested change

	PosixFlavour = pathlib.PurePosixPath
	PosixFlavour = Mock

as we probably don't want to really mock posixpath and now it is still clear that flavour is something different.

[yunzheng]

This change gives me an error:

.tox/py3/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
tests/test_fieldtypes.py:558: in <module>
    (custom_pure_path(sep="/", altsep="")("/foo/bar"), True),
tests/test_fieldtypes.py:547: in custom_pure_path
    class PureCustomPath(pathlib.PurePath):
tests/test_fieldtypes.py:548: in PureCustomPath
    _flavour = CustomFlavour()
tests/test_fieldtypes.py:543: in __new__
    instance.sep = sep
/usr/local/lib/python3.12/unittest/mock.py:771: in __setattr__
    elif (self._spec_set and self._mock_methods is not None and
/usr/local/lib/python3.12/unittest/mock.py:656: in __getattr__
    elif self._mock_methods is not None:
/usr/local/lib/python3.12/unittest/mock.py:655: in __getattr__
    raise AttributeError(name)
E   AttributeError: _mock_methods

[yunzheng]

@pyrco any ideas?

[pyrco]

I had this change in mind. It's not a real mock of posixpath/ntpath but for the testcase purposes it is sufficient.

[pyrco]

Ok, this didn't work as expected, I'll have to look a bit more into it

[yunzheng]

Ok, this didn't work as expected, I'll have to look a bit more into it

any luck with this?

[Schamper]

I've pushed a possible fix for the unit test.

[pyrco]

Yes, that is the mock I was looking for 😉