Refactor and improve CSV adapter #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 80.00% 80.06% +0.05%
==========================================
Files 33 33
Lines 3101 3110 +9
==========================================
+ Hits 2481 2490 +9
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yunzheng
force-pushed
the
refactor/csv-adapter
branch
from
2950409
to
fb261db
Compare
This change allows the CSV adapter to: - ability to read reserved fields (eg: _generated, _source, etc) - use `normalize_fieldname` to normalize field names in flow.record - deduce format of csv file automatically by using `csv.Sniffer`
yunzheng
force-pushed
the
refactor/csv-adapter
branch
from
fb261db
to
509badd
Compare
Schamper
previously approved these changes
Nov 18, 2023
Schamper
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the CSV adapter to:
clean_fieldnamethat otherwise are invalid names in flow.recordcsv.Sniffer