Skip to content

Commit

Permalink
Add esm module distribution
Browse files Browse the repository at this point in the history
  • Loading branch information
mtorromeo committed Dec 19, 2018
1 parent 0e6fa13 commit 9e2d046
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "3.5.0",
"description": "Async computed properties for Vue",
"main": "dist/vue-async-computed.js",
"module": "dist/vue-async-computed.esm.js",

This comment has been minimized.

Copy link
@adamchenwei

adamchenwei Jan 29, 2019

Is module a standard property, @mtorromeo? because so far I see its not but only for rollbar. https://stackoverflow.com/questions/42708484/what-is-the-module-package-json-field-for
Also, this is breaking IE support because its importing esm version that does not compile function properly because its using es6 formating (i.e. in compiled js, we have get() instead of correct way of function get())
Please remove this config from the package.json if possible. thank you.

"files": [
"bin/",
"dist/"
Expand All @@ -14,8 +15,9 @@
"watch": "watch 'npm run build' src test",
"test": "babel-node --presets env test/index.js | tspec",
"prebuild": "npm run check -s && npm run clean -s && mkdirp dist",
"build": "npm run rollup -s && npm run babel -s",
"rollup": "rollup src/index.js --output.format umd --name AsyncComputed --output.file dist/vue-async-computed.esnext.js",
"build": "npm run rollup-esm -s && npm run rollup-umd -s && npm run babel -s",
"rollup-esm": "rollup src/index.js --output.format esm --name AsyncComputed --output.file dist/vue-async-computed.esm.js",
"rollup-umd": "rollup src/index.js --output.format umd --name AsyncComputed --output.file dist/vue-async-computed.esnext.js",
"babel": "babel --optional runtime dist/vue-async-computed.esnext.js --out-file dist/vue-async-computed.js",
"postbuild": "npm run test -s",
"coverage": "node_modules/.bin/babel-node node_modules/.bin/babel-istanbul cover test/index.js",
Expand Down

0 comments on commit 9e2d046

Please sign in to comment.