Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending messages to domains without MX records fails #321

Closed
foxcpp opened this issue Dec 15, 2020 · 1 comment
Closed

Sending messages to domains without MX records fails #321

foxcpp opened this issue Dec 15, 2020 · 1 comment
Assignees
Labels
bug Something isn't working. mta-out Related to MSA or outgoing message processing part of MTA functionality.

Comments

@foxcpp
Copy link
Owner

foxcpp commented Dec 15, 2020

Describe the bug

Something goes wrong when maddy tries to use non-MX hostname.

Log files

remote: cannot use MX   {"domain":"aaa","msg_id":"f2423444-5fd6ff38","reason":"dns: domain must be fully qualified","remote_server":"aaa","tls_err":null}
queue: delivery attempt failed  {"domain":"aaa","msg_id":"f2423444","rcpt":"mysh@aaa","reason":"dns: domain must be fully qualified","smtp_code":451,"smtp_enchcode":"5.4.0","smtp_msg":"No usable MXs, last err: dns: domain must be fully qualified","target":"remote","tls_err":null}
queue: not delivered, permanent error   {"msg_id":"f2423444","rcpt":"mysh@aaa"}

Environment information

  • maddy version: 0.4.3
@foxcpp foxcpp added bug Something isn't working. mta-out Related to MSA or outgoing message processing part of MTA functionality. labels Dec 15, 2020
@foxcpp foxcpp self-assigned this Dec 23, 2020
@foxcpp foxcpp closed this as completed in fe97356 Dec 24, 2020
@foxcpp
Copy link
Owner Author

foxcpp commented Dec 24, 2020

miekg/dns library returns an error if domain passed to dns.TLSAName is not a FQDN. Per discussion in #311 we just force it to be one. This is affecting only cases where there are no MX records since domains in MX records are FQDNs.

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. mta-out Related to MSA or outgoing message processing part of MTA functionality.
Projects
None yet
Development

No branches or pull requests

1 participant