This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Switch to explicit api versions #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
reviewed
Dec 13, 2019
src/app/endpoint/message.rs
Outdated
| let response_topic = Subscription::multicast_requests_from(to) | ||
| .subscription_topic(&self.me) | ||
| let response_topic = Subscription::multicast_requests_from(to, Some("v1")) | ||
| .subscription_topic(&self.me, "v1") |
There was a problem hiding this comment.
Isn't that the current agent's version (Conference)?
src/app/endpoint/mod.rs
Outdated
| @@ -120,7 +120,8 @@ where | |||
| .build(); | |||
|
|
|||
| let timing = ShortTermTimingProperties::until_now(start_timestamp); | |||
| let resp = OutgoingResponse::unicast(err, props.to_response(status, timing), props); | |||
| let resp = | |||
| OutgoingResponse::unicast(err, props.to_response(status, timing), props, "v1"); | |||
There was a problem hiding this comment.
For any response we already know its version. It presented in the related request.
feymartynov
force-pushed
the
feature/ULMS-711
branch
from
f1017d9
to
bd48d40
Compare
manifest
approved these changes
Dec 16, 2019
feymartynov
force-pushed
the
feature/ULMS-711
branch
from
d8e29ef
to
13edbf3
Compare
feymartynov
force-pushed
the
feature/ULMS-711
branch
from
13edbf3
to
67374c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.