Communicate supported encodings for client-side publishing #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Jan 11, 2023
| @@ -62,14 +62,16 @@ class FoxgloveBridge : public rclcpp::Node { | |||
| if (_useSimTime) { | |||
| serverCapabilities.push_back(foxglove::CAPABILITY_TIME); | |||
| } | |||
| const std::vector<std::string> supportedEncodings = {"cdr"}; | |||
There was a problem hiding this comment.
why doesn't this one use a static constant when the other one does?
There was a problem hiding this comment.
I guess because we originally planned to support both cdr and idl. Will change it in the future when we have some time for cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Corresponding spec PR: foxglove/ws-protocol#326