Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for optional request id for setParameter operation #133

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Add support for optional request id for setParameter operation #133

merged 2 commits into from
Jan 11, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Jan 10, 2023

Public-Facing Changes

  • Add support for optional request id for setParameter operation

Description
Corresponding spec PR: foxglove/ws-protocol#328:

The server may reject requests to update parameters for various reasons such as e.g. parameters being readonly. To allow a client to verify if parameter updates were successful, this PR adds an optional request ID field to the setParameters operation.

@achim-k achim-k merged commit 9f3e62f into main Jan 11, 2023
@achim-k achim-k deleted the achim/request_id_support branch January 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhurliman jhurliman jhurliman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achim-k @jhurliman