Performance improvements #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
approved these changes
Feb 8, 2023
achim-k
added a commit
that referenced
this pull request
Feb 13, 2023
**Public-Facing Changes** - Add option to use permessage-deflate compression **Description** - Add option to use permessage-deflate compression Found out that this was possible when implementing #151. Not sure if it is really useful tho, the additional CPU load is quite high (I can provide some measurements on request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
This PR makes some minor performance improvements:
websocketpp::endpoint< connection, config >::send(connection_hdl hdl, message_ptr msg)std::array<uint8_t, N>to avoid heap allocationTo measure performance improvments, I wrote a test client that prints some channel statistics: foxglove/ws-protocol#361. The table below shows the average CPU time and data received (over 4 runs) when playing back
realsense-ros2-001.mcap:We can see that this PR significantly reduces CPU load while the data throughput remains almost the same (statistically speaking probably not significantly different)