Add sessionId to serverInfo #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
commented
Feb 8, 2023
| serverOptions.supportedEncodings = {"cdr"}; | ||
| serverOptions.metadata = {{"ROS_DISTRO", std::getenv("ROS_DISTRO")}}; | ||
| serverOptions.sendBufferLimitBytes = send_buffer_limit; | ||
| serverOptions.sessionId = std::to_string(std::time(0)); |
There was a problem hiding this comment.
Should we make this configurable via a ROS param?
There was a problem hiding this comment.
I vote no, I don't think it opens up any new use cases. It's too bad ROS 2 lost the concept of /run_id.
jhurliman
reviewed
Feb 8, 2023
jhurliman
reviewed
Feb 8, 2023
Co-authored-by: John Hurliman <jhurliman@jhurliman.org>
jhurliman
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
sessionIdtoserverInfoDescription
sessionIdtoserverInfo(see Spec: Add optionalsessionIdfield toserverInfomessage ws-protocol#360)/run_idparameter andstd::time(0)if the parameter is not setstd::time(0)