Improve mutex usage #154
Merged
Improve mutex usage #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
reviewed
Feb 8, 2023
| sendJson(hdl, { | ||
| {"op", "advertise"}, | ||
| {"channels", std::move(channels)}, | ||
| }); |
There was a problem hiding this comment.
Can this be modified to move the sendJson call outside of the lock? Declare std::vector<Channel> channels; above and only populate it inside the lock.
There was a problem hiding this comment.
yap, that makes sense. Will do
jhurliman
approved these changes
Feb 8, 2023
| sendJson(hdl, { | ||
| {"op", "advertiseServices"}, | ||
| {"services", std::move(services)}, | ||
| }); |
There was a problem hiding this comment.
Same question/comment here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
_clientsChannelMutexinto_clientsMutexand_channelsMutex_clientChannelsMutexfor protecting client channels