Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 parameter fixes #169

Merged
merged 2 commits into from
Feb 17, 2023
Merged

ROS2 parameter fixes #169

merged 2 commits into from
Feb 17, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 17, 2023

Public-Facing Changes

  • Avoids attempting to fetch parameters from nodes that do not offer services to list / get parameters
  • Fixes temporary rclcpp::AsyncParametersClient instances being created

Description

  • When clients were fetching all available parameters (via {"op": "getParameters", "parameterNames": []}), we were attempting to fetch parameters from all available nodes, even from nodes that do not offer services for listing / getting paramters. This PR changes this to consider only nodes that offer these services
  • Fixes temporary instances of rclcpp::AsyncParametersClient being created

@achim-k achim-k merged commit 13e6135 into main Feb 17, 2023
@achim-k achim-k deleted the achim/ros2_param_fixes branch February 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhurliman jhurliman jhurliman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achim-k @jhurliman