Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-advertising existing channels when advertising new channels #172

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 22, 2023

Public-Facing Changes

  • Avoid re-advertising existing channels when advertising new channels

Description
When new channels are advertised, we broadcast all available channels to clients rather than just the newly added ones. This PR fixes it.

Fixes #146
Fixes FG-1793

@achim-k
Copy link
Collaborator Author

achim-k commented Feb 28, 2023

Pinging for review @jhurliman @jtbandes

Copy link
Contributor

@jhurliman jhurliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you port this change to ws-protocol repo too?

@achim-k
Copy link
Collaborator Author

achim-k commented Feb 28, 2023

Can you port this change to ws-protocol repo too?

Already done. I have ported the version of this PR

@achim-k achim-k merged commit 8834275 into main Feb 28, 2023
@achim-k achim-k deleted the achim/avoid_readvertising_channels branch February 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Broadcast only newly added channels instead of all existing channels
2 participants