Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the way compiler flags are set, use clang as default compiler #175

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Improve the way compiler flags are set, use clang as default compiler #175

merged 3 commits into from
Feb 28, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 28, 2023 •
edited
Loading

Public-Facing Changes

  • None

Description

  • Use target_compile_options instead of manually setting the CMAKE_CXX_FLAGS
  • Use clang as default compiler
  • Set default build type to RelWithDebInfo
  • Remove some stuff regarding address sanitization. One can pass the necessary option also via --cmake-args

Fixes #173
Fixes FG-2156

@achim-k achim-k force-pushed the achim/compiler_flags_and_clang branch from 49325c7 to be085b1 Compare February 28, 2023 21:09
@achim-k achim-k force-pushed the achim/compiler_flags_and_clang branch from be085b1 to 150eace Compare February 28, 2023 21:12
@achim-k achim-k merged commit 9e3d060 into main Feb 28, 2023
@achim-k achim-k deleted the achim/compiler_flags_and_clang branch February 28, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhurliman jhurliman jhurliman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm that CI catches all compiler warnings / errors
2 participants
@achim-k @jhurliman