Add parameter client_topic_whitelist for whitelisting client-published topics
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Mar 7, 2023
README.md
Outdated
| @@ -32,7 +32,7 @@ To run the bridge node, it is recommended to use the provided launch file: | |||
| **ROS 1** | |||
|
|
|||
| ```bash | |||
| $ roslaunch --screen foxglove_bridge foxglove_bridge.launch port:=8765 | |||
| $ roslaunch --screen foxglove_bridge foxglove_bridge.launch port:=8765 # topic_whitelist:=[/foo/.*,/bar/baz] | |||
There was a problem hiding this comment.
Comment syntax could be confusing
jtbandes
approved these changes
Mar 7, 2023
achim-k
force-pushed
the
achim/topic_whitelist_client_channel
branch
from
bf55655
to
fd6ea25
Compare
achim-k
changed the title
client_topic_whitelist for whitelisting client-published topics
jtbandes
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
client_topic_whitelistfor whitelisting client-published topicsDescription
Fixes #180