Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server capabilities configurable #182

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Mar 7, 2023

Public-Facing Changes

  • Make server capabilities configurable

Description

Allows the user to configure server capabilities via a ROS parameter. By default, all capabilities are enabled. Note that the time capability is not configurable as it depends solely on /use_sim_time.

Example usage:

roslaunch foxglove_bridge foxglove_bridge.launch capabilities:=[parameters,connectionGraph]

Fixes #180

@achim-k achim-k requested a review from jtbandes March 7, 2023 18:40
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get integration tests some day that can cover this functionality.

@achim-k
Copy link
Collaborator Author

achim-k commented Mar 7, 2023

Would be great to get integration tests some day that can cover this functionality.

Totally agree. I will add a ticket for this.

@achim-k achim-k merged commit de37eb6 into main Mar 7, 2023
@achim-k achim-k deleted the achim/configurable_capabilities branch March 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[ROS1] Topic whitelist is not bidirectional
2 participants