Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS1] Fix exception not being caught when retrieving service type #190

Merged
merged 3 commits into from
Mar 9, 2023
Merged

[ROS1] Fix exception not being caught when retrieving service type #190

merged 3 commits into from
Mar 9, 2023

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Mar 9, 2023 •
edited
Loading

Public-Facing Changes

  • Fix exception not being caught when retrieving service type [ROS1]

Description

Fixes FG-2399

@achim-k achim-k requested a review from jtbandes March 9, 2023 19:28
@achim-k achim-k force-pushed the achim/harden_service_type_retrieval branch from 302b6c5 to 66c1aad Compare March 9, 2023 20:28
@achim-k achim-k enabled auto-merge (squash) March 9, 2023 20:31
@achim-k achim-k merged commit 51fd89a into main Mar 9, 2023
@achim-k achim-k deleted the achim/harden_service_type_retrieval branch March 9, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updateAdvertisedServices terminates the WebSocket connection in Foxglove Bridge node
2 participants
@achim-k @jtbandes