Notify client when Server's send buffer limit has been reached #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2500); | ||
| const auto logFn = [this, clientHandle]() { | ||
| sendStatusAndLogMsg(clientHandle, StatusLevel::Warning, | ||
| "Connection send buffer limit reached, messages will be dropped..."); |
There was a problem hiding this comment.
As a user I'd find it more helpful if this said something like "Server send buffer full. Dropping message on topic /foo/bar".
There was a problem hiding this comment.
I agree that this would be more helpful, but due to log debounce, you wouldn't see it for every topic for which messages are dropped
defunctzombie
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Before we merge and release this - we need to talk through (or experiment/experience) what the client side will look like with this new message spam. My read of the way things are implemented here is if we turned every warning/error status into a "player problem" in Studio we will quickly fill up the list of problems and overrun the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Rather than only logging a message, the client is now also informed when the server is about to drop messages due to the send buffer limit being exceeded. See #174 (comment)