Fix unhandled xmlrpc exception #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Apr 20, 2023
jtbandes
reviewed
Apr 20, 2023
| } catch (const XmlRpc::XmlRpcException& ex) { | ||
| ROS_ERROR("Failed to update parameter: %s", ex.getMessage().c_str()); | ||
| } catch (...) { | ||
| ROS_ERROR("Failed to update parameter"); |
There was a problem hiding this comment.
Is there any way to include more info about the exception type in the log? I googled a little bit and couldn't find anything... I see that you can use current_exception() to get an exception_ptr, but then there's nothing useful you can do with that 😬
There was a problem hiding this comment.
I'm also not aware that this would be possible. Also just learned that you can literally throw anything, e.g. just throw 1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
Addresses the crash reported in #217