Add support for nested parameters (ROS1) #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
force-pushed
the
achim/fg-3016-support-nested-params
branch
from
8b6ca51
to
cc07ce7
Compare
jtbandes
reviewed
May 4, 2023
You are right, completely forgot that since it already works with Studio out of the box. Will update the spec Edit: foxglove/ws-protocol#434 |
jtbandes
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
This PR adds support for parameter maps and arrays of parameter maps (ROS 1 only). To accomplish that, the existing
Parameterclass has been split up into aParameterValueclass which facilitates conversion to/fromxmlrpc::XmlRpcValue.Spec update: foxglove/ws-protocol#434
Fixes #219