Fix ROS2 launch file install rule not installing launch subfolder

[memtech3]

Public-Facing Changes

Fix ROS2 launch file install rule not installing launch subfolder

Description

ROS2 launch file snippet in README.md had incorrect path to foxglove bridge launch file <include file="$(find-pkg-share foxglove_bridge)/launch/foxglove_bridge_launch.xml">. Path should be <include file="$(find-pkg-share foxglove_bridge)/foxglove_bridge_launch.xml">

Fixes #242
Fixes FG-4181

[CLAassistant]

All committers have signed the CLA.

[memtech3]

Fixes #242

[memtech3]

ROS Melodic Test fails during step make melodic-test with message

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
foxglove_bridge: Cannot locate rosdep definition for [ros_babel_fish]
The command '/bin/sh -c . /opt/ros/$ROS_DISTRO/setup.sh &&     apt-get update && rosdep update && rosdep install -y       --from-paths         src       --ignore-src     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 1
make: *** [Makefile:13: melodic] Error 1

Error: Process completed with exit code 2.

Is this a foxglove_bridge bug?

[achim-k]

Thanks for the contribution!

While this change is technically correct, I think it would be better to fix the install rule by removing the trailing slash on line 258. The launch file should be installed in the launch directory, but the current install rules installed it in the package share root directory.

ros-foxglove-bridge/CMakeLists.txt

Lines 258 to 260 in e336bbc

	install(DIRECTORY ros2_foxglove_bridge/launch/
	DESTINATION share/${PROJECT_NAME}/
	)

[achim-k]

ROS Melodic Test fails during step make melodic-test with message

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
foxglove_bridge: Cannot locate rosdep definition for [ros_babel_fish]
The command '/bin/sh -c . /opt/ros/$ROS_DISTRO/setup.sh &&     apt-get update && rosdep update && rosdep install -y       --from-paths         src       --ignore-src     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 1
make: *** [Makefile:13: melodic] Error 1

Error: Process completed with exit code 2.

Is this a foxglove_bridge bug?

No, this is due to melodic being EOL. I have pushed a commit that adds --include-eol-distros to rosdep update but it's not merged yet.

Edit: Merged a PR that fixes melodic CI builds

[memtech3]

Thanks for the contribution!

While this change is technically correct, I think it would be better to fix the install rule by removing the trailing slash on line 258. The launch file should be installed in the launch directory, but the current install rules installed it in the package share root directory.

ros-foxglove-bridge/CMakeLists.txt

Lines 258 to 260 in e336bbc

	install(DIRECTORY ros2_foxglove_bridge/launch/
	DESTINATION share/${PROJECT_NAME}/
	)

I've updated my branch with that change

[memtech3]

Change might have made the CI tests failed, investigating

[achim-k]

I think you have to remove the trailing slash one line above (L258)

[achim-k]

I have added the required change. Thanks for your contribution @memtech3!

[memtech3]

I have added the required change. Thanks for your contribution @memtech3!

Thanks! Can you explain the cmake behavior? I'm a little new to C++ and ROS2