Avoid usage of tmpnam() for creating random filename #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Jul 11, 2023
Not available under windows. Not a target OS, but it would be good if we could keep foxglove bridge building with robotstack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Avoid usage of tmpnam() for creating random filename
Description
Follow up of #232. ROS build farm complained about usage of
tmpnam. This PR replaces it by using the epoch time in milliseconds to create a somewhat random filename (used for tests only)https://build.ros2.org/job/Idev__foxglove_bridge__ubuntu_jammy_amd64/9/