Support building with boost asio #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Jul 11, 2023
| @@ -179,17 +187,18 @@ if(ROS_BUILD_TYPE STREQUAL "catkin") | |||
| find_package(GTest REQUIRED) | |||
| endif() | |||
| find_package(rostest REQUIRED) | |||
| find_package(Boost REQUIRED COMPONENTS system) | |||
There was a problem hiding this comment.
Should we do this conditionally based on the flags chosen?
There was a problem hiding this comment.
We could, but ROS1 depends on boost anyways, so it does not hurt to have it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Support building with boost asio
Description
Avoids a hard dependency on standalone asio and provides users with more flexibility when using foxglove_bridge in a bigger project. Related: foxglove/ws-protocol#483
Successfully built and tested melodic & noetic with boost asio. I think it would make sense to add a test for this as well.