Server code improvements #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Jul 13, 2023
| @@ -38,6 +38,29 @@ | |||
| } \ | |||
| } | |||
|
|
|||
| namespace { | |||
|
|
|||
| constexpr uint32_t Integer(const std::string_view str) { | |||
There was a problem hiding this comment.
this function should probably be named StringHash or something that actually explains what it does.
Is there any compile time guarantee that the strings we use it with actually hash to different values? I guess we would hope to get a compile error if it resulted in a switch with multiple identical cases?
edit: but I see we are not using switch..
There was a problem hiding this comment.
Renamed it and changed it back to a switch
Comment on lines
377
to
378
| } catch (...) { | ||
| } |
There was a problem hiding this comment.
Why do nothing here? Seems like we should log an error if possible?
| default: { | ||
| try { | ||
| const auto intOp = Integer(op); | ||
| if (intOp == SUBSCRIBE) { |
| inline bool Server<ServerConfiguration>::hasHandler(uint32_t op) const { | ||
| switch (op) { | ||
| case SUBSCRIBE: | ||
| return static_cast<bool>(_handlers.subscribeHandler); |
There was a problem hiding this comment.
nit: you can just do bool(...)
achim-k
added a commit
that referenced
this pull request
Jul 17, 2023
### Public-Facing Changes Fix segfault due to invalid iterator ### Description Fixes a segfault caused by using an invalid iterator as argument to `std::unordered_map<...>::erase`. This regression was introduced in #250.
achim-k
added a commit
that referenced
this pull request
Jul 25, 2023
### Public-Facing Changes Fix specific exceptions not being caught ### Description Fixes specific exceptions not being caught, leading to vague error messages. This regression got introduced with #250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Refactor server code, improve multi-threading safety
Description
Addresses comments from foxglove/ws-protocol#491. These changes will be applied to that PR once this PR gets merged.