Reduce smoke test flakiness #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROS1 server does not listen on graph changes, but instead periodically queries the ROS master for changes regarding available topics or services. The max. period between two consecutive ROS master queries is 5 seconds (default), hence we have to use the same timeout in the test.
jtbandes
approved these changes
Aug 14, 2023
achim-k
added a commit
that referenced
this pull request
Aug 14, 2023
### Public-Facing Changes Handle client disconnection in message handler thread ### Description This is a minor improvement that I noticed when working on #258. It may happen that the close handler is called before the last message of the client (e.g. `unsubscribe`) is handled which can lead to exceptions being raised when [accessing the `_clients` map](https://github.com/foxglove/ros-foxglove-bridge/blob/d78de15b5f1248513dee2ff3566e81e6eac943d0/foxglove_bridge_base/include/foxglove_bridge/websocket_server.hpp#L1252) (as the client has been removed from that map already). By also handling close events in the message handler thread, we ensure that the close handler is always called last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Reduce smoke test flakiness
Description
Attempt to fix flaky smoke tests:
ROS 1
ROS 2