Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dual ROS 1+2 devcontainer, remove ROS Galactic from the support matrix #285

Merged
merged 4 commits into from Feb 14, 2024

Conversation

jhurliman
Copy link
Contributor

Public-Facing Changes

  • ROS Galactic support has been dropped from the support matrix

Description

In anticipation of adding ROS 2-specific functionality that relies on ROS Humble or later, ROS Galactic has been removed from the support matrix. The dual ROS 1+2 devcontainer has been replaced with a ROS 2 Humble devcontainer that matches what is used in CI.

Copy link
Collaborator

@achim-k achim-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In anticipation of adding ROS 2-specific functionality that relies on ROS Humble or later, ROS Galactic has been removed from the support matrix.

Does that mean that your anticipated changes will prevent users from manually building foxglove_bridge for galactic?

.vscode/c_cpp_properties.json Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@achim-k achim-k merged commit 89239eb into foxglove:main Feb 14, 2024
10 checks passed
@jhurliman
Copy link
Contributor Author

In anticipation of adding ROS 2-specific functionality that relies on ROS Humble or later, ROS Galactic has been removed from the support matrix.

Does that mean that your anticipated changes will prevent users from manually building foxglove_bridge for galactic?

Yes, that's correct. Once ros2_babel_fish code is vendored into this repo, anyone trying to build ros-foxglove-bridge against a ROS 2 release before Humble will see compilation errors about trying to call methods that don't exist.

@jhurliman jhurliman deleted the jhurliman/split-containers branch February 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants