send service call failure operation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
reviewed
May 13, 2024
foxglove_bridge_base/include/foxglove_bridge/websocket_server.hpp
Outdated
Show resolved
Hide resolved
jtbandes
approved these changes
May 13, 2024
Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
|
@jtbandes can you merge this overruling the rolling CI checks? |
jtbandes
deleted the
achim/fg-7459-foxglove-bridge-send-servicecallfailure-on-service-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Docs
Description
Similar to foxglove/ws-protocol#743, this PR implements the recently added
serviceCallFailureoperation that was added inhttps://github.com/foxglove/ws-protocol/pull/733. This operation is sent to a client when the service call failed or if the service could not be found to avoid that the client potentially waits forever for a service response message.