Fix srv definition parsing failing due to carriage return #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tonynajjar |
|
Rolling CI tests are still failing -> #304 |
jtbandes
approved these changes
Jun 11, 2024
|
This was the only place where we did a string comparison, for other places we do not have to handle different line endings. |
Merged
jtbandes
pushed a commit
that referenced
this pull request
Jun 13, 2024
### Changelog - Fix srv definition parsing failing due to carriage return (#303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix srv definition parsing failing due to carriage return
Docs
None
Description
Fixes srv (or action) definition parsing failing when the definition seperator
---is terminated with\r\ninstead of just\n. More details in #301.Fixes: #301