Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing field names which start with a number #425

Merged
merged 1 commit into from Jul 20, 2018

Conversation

svirschevskiy
Copy link
Contributor

It fixes parsing field names which start with numbers

const fields =  [{
    name: "1a",
    value: " "
  },  {
    name: "2a",
    value: " "
  },  {
    name: "3a",
    value: " "
 }]

Actual result

form.values() // [" ", " ", " "]

Expected result

form.values() // {"1s": " ", "2s": " ", "3s": " "}

@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         112      112           
  Lines        2213     2213           
=======================================
  Hits         2122     2122           
  Misses         91       91
Impacted Files Coverage Δ
src/parser.js 98.83% <ø> (ø) ⬆️
src/utils.js 94.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dab427...bfa1dcc. Read the comment docs.

@foxhound87
Copy link
Owner

@rezzzet thank you for this PR, I have to write the tests before release it.

@foxhound87
Copy link
Owner

@rezzzet why did you added the build directory?

@svirschevskiy
Copy link
Contributor Author

svirschevskiy commented Jun 29, 2018

@foxhound87 oh, it was accidentally pushed to wrong branch. thanks for caught it.

@foxhound87 foxhound87 merged commit bfa1dcc into foxhound87:master Jul 20, 2018
foxhound87 added a commit that referenced this pull request Jul 20, 2018
foxhound87 added a commit that referenced this pull request Jul 20, 2018
foxhound87 added a commit that referenced this pull request Jul 20, 2018
@foxhound87
Copy link
Owner

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants