propagate user-set Spark configurations to the driver pod #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Annotate this as associated with kubernetes/kubernetes#34377 |
|
Merging. Thanks @erikerlandson. |
foxish
pushed a commit
that referenced
this pull request
Dec 2, 2016
kimoonkim
reviewed
Dec 22, 2016
| s"--conf spark.executor.jar=$clientJarUri") | ||
|
|
||
| submitArgs ++= conf.getAll.filter { case (name, _) => !confBlackList.contains(name) } | ||
| .map { case (name, value) => s"--conf ${name}=${value}" } |
There was a problem hiding this comment.
Hi @erikerlandson and @foxish
Thanks for writing this change! I was looking at this because it would fix an issue I was having.
But it seems that line 113-114 appending to submitArgs are missing in the latest revision of KubernetesClusterScheduler.scala. I wonder if they were intentionally removed?
Thanks,
Kimoon
There was a problem hiding this comment.
It must have been omitted in one of the commits. I will add the change in my next commit.
Thanks for pointing that out.
There was a problem hiding this comment.
Hi @iyanuobidele,
That makes sense. Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to propagate all user-configured settings to the driver running in the cluster. As a corollary, all of the dynamic executor configuration parameters are passed along, and so dynamic executor behavior is now fully configurable:
http://spark.apache.org/docs/latest/configuration.html#dynamic-allocation
Use spark image:
manyangled/kube-spark:dynamic