Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of sysgpu alongside Dawn #44

Merged
merged 42 commits into from
Jan 17, 2024
Merged

Enable the use of sysgpu alongside Dawn #44

merged 42 commits into from
Jan 17, 2024

Conversation

foxnne
Copy link
Owner

@foxnne foxnne commented Jan 16, 2024

Closes #17.

This is a very large PR changing the Dear Imgui bindings used in the project and allows for a new sysgpu backend to be used which fixes a very long-standing bug/leak on macOS. I'm eager to merge this, but mach-core I believe is waiting on changes to the zig build system to allow optional dependencies, or to vendor prebuilt binaries for a dependency that adds a lot of build time.

I likely shouldn't have but I continued development in this branch and many of those changes are here as well. I will merge this as soon as its not broken on Windows without edits, See here, and mach-core reenables sysgpu. See here

@foxnne foxnne added the enhancement New feature or request label Jan 16, 2024
@foxnne foxnne self-assigned this Jan 16, 2024
@foxnne foxnne changed the title Enable the use of sysgpu instead of Dawn Enable the use of sysgpu alongside Dawn Jan 17, 2024
@foxnne foxnne marked this pull request as ready for review January 17, 2024 15:45
@foxnne foxnne merged commit 6d7e96e into main Jan 17, 2024
@foxnne foxnne deleted the sysgpu branch February 26, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Window freezes and flashes magenta unpredictably on random file loads
1 participant