parser: Add unused var check #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit eb090bd): https://evy-lang--pr24-unused-decl-nux50pp5.web.app (expires Wed, 12 Oct 2022 12:13:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
juliaogris
force-pushed
the
unused-decl
branch
3 times, most recently
from
8e75fdd
to
78fb9bf
Compare
|
Hi from GitHub CLI |
juliaogris
force-pushed
the
unused-decl
branch
4 times, most recently
from
0450cdf
to
2237001
Compare
camh-
reviewed
Oct 6, 2022
juliaogris
force-pushed
the
unused-decl
branch
2 times, most recently
from
6da552f
to
0103456
Compare
Rename validateVar to validateVarDecl as it is more accurate and less confusing on revisit: validateVarDecl ensures that a declartion of a variable doesn't use a function name or an already declared variable name from same local scope.
Fix location for unknown variable error message so that it actually points to the column where the unknown variable starts and not to the next token after it.
Add unused var check reporting an error if declared variable is never used. This feature was yet again borrowed from go and piggy backed on the scope data structure.
juliaogris
force-pushed
the
unused-decl
branch
from
0103456
to
928d849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unused var check reporting an error if declared variable is never
used. This feature was yet again borrowed from go and piggy backed on
the scope data structure.
Refactor
validateVartovalidateVarDeclas it seems the moreappropriate name.