add detailed info about feature; enable transition by name; enable r… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshkg
force-pushed
the
details_to_issue_and_transition_by_name
branch
from
2ff0584
to
ed5e1c9
Compare
|
@alexadept I like this PR can you please fix the conflicts with master to finish the review process? thanks a lot! |
|
ok, will do it next days |
nshkg
force-pushed
the
details_to_issue_and_transition_by_name
branch
from
ed5e1c9
to
1ac8099
Compare
|
I updated my PR. I apologize - it was not so fast, as I hoped for. Also, I suppose that would be fine to update docs together. How can I do it? |
miguelmich
requested changes
Dec 3, 2018
| @@ -71,11 +72,13 @@ jira.init().then(function(){ | |||
| .command('issue [command]') | |||
| .description('Issue commands') | |||
| .alias('i') | |||
| .option("-d, --details", "Print issue detailed info") | |||
There was a problem hiding this comment.
@alexadept where are you passing this option to the findIssue method? I can't find it, are you currently able to trigger the detailed condition?
I think we'll need to pass the detail option (if it's present) here:
Lines 286 to 289 in 704defd
What do you think?
|
i also like this PR. maybe we can get a maintainer to update it and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aw jql queries