Generic Main should fail fast on converting options to enums.

[fozziethebeat]

Running

java -Xmx2g -cp target/sspace-2.0.3-jar-with-dependencies.jar edu.ucla.sspace.mains.LSAMain -d test.doc -o dense_text .

processes the corpus using SVD and then attempts to convert the value of -o (dense_text) to a edu.ucla.sspace.common.SemanticSpaceIO.SSpaceFormat enum after the processing only to fail, since it's an incorrect value. This should fail before any processing to save time and computational resources.

[davidjurgens]

Is this just missing the toUpperCase() to match the enum's .valueOf()
casing?

On Thu, Jul 26, 2012 at 1:36 AM, Keith Stevens <
reply@reply.github.com

wrote:

Running

java -Xmx2g -cp target/sspace-2.0.3-jar-with-dependencies.jar

edu.ucla.sspace.mains.LSAMain -d test.doc -o dense_text .

processes the corpus using SVD and then attempts to convert the value of
-o (dense_text) to a edu.ucla.sspace.common.SemanticSpaceIO.SSpaceFormat
enum after the processing only to fail, since it's an incorrect value.
This should fail before any processing to save time and computational
resources.

---

Reply to this email directly or view it on GitHub:
#18

[fozziethebeat]

Nope, DENSE_TEXT isn't a valid option, TEXT is. Either way, it should fail fast.

[fozziethebeat]

Commit bcd5b9f fixes this issue.