This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
Small clean up and added some tests #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gurustron
commented
Sep 8, 2020
•
gurustron
commented
- Removed rethrowing exceptions (fixes Don't catch-and-throw #29)
- Very minor refactorings in some places.
- Added some tests
|
@fpanaccia can you please fix AppVeyor build and tests to it? |
|
Hi!, i had planning to delete AppVeyor and use github actions...i just did the upload...i will add the testing in the weekend |
|
@fpanaccia Thank you! |
|
@fpanaccia can you somehow setup actions to be run only on main repo, not the forks? |
|
it seems that there is a workaround....but i think i gonna remove the action and use azure devops |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.