2023-12-09 Fredy Paquet <mailbox AT opag.ch>

* fixed crash, caused by _gtk_sheet_position_children() in frozen sheet 321874
fpaquet · Dec 9, 2023 · 2e1c930 · 2e1c930
1 parent f18dfd7
commit 2e1c930
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -8,6 +8,9 @@ TBD - known bugs
 (opg:19745): Gtk-WARNING **: GtkSheet 0x2816110 (line) is mapped but visible child GtkDataEntry 0x214c560 (GtkDataEntry) is not mapped
 ** (testgtksheet:19815): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton
 
+2023-12-09 Fredy Paquet <mailbox AT opag.ch>
+* fixed crash, caused by _gtk_sheet_position_children() in frozen sheet 321874
+
 2023-10-09 Fredy Paquet <mailbox AT opag.ch>
 * fixed children visibility (attached_to_cell), on column hide/show 320079
 * fixed width of column title button removes drawing artefacts in title area 0318674

diff --git a/gtksheet/gtksheet.c b/gtksheet/gtksheet.c
@@ -19594,18 +19594,22 @@ _gtk_sheet_position_children(GtkSheet *sheet)
     GtkSheetChild *child;
 
 #if GTK_SHEET_DEBUG_CHILDREN > 0
-    g_debug("%s(%d): sheet %s %p visible %d realized %d mapped %d", 
+    g_debug("%s(%d): sheet %s %p visible %d realized %d mapped %d frozen %d", 
         __FUNCTION__, __LINE__,
         G_OBJECT_TYPE_NAME(sheet), sheet, 
         gtk_widget_get_visible(GTK_WIDGET(sheet)),
         gtk_widget_get_realized(GTK_WIDGET(sheet)),
-        gtk_widget_get_mapped(GTK_WIDGET(sheet))
+        gtk_widget_get_mapped(GTK_WIDGET(sheet)),
+        GTK_SHEET_IS_FROZEN(sheet)
         );
 #endif
 
     if (!gtk_widget_get_realized(GTK_WIDGET(sheet)))
 	return;
 
+    if (GTK_SHEET_IS_FROZEN(sheet))
+        return;
+
     while (children)
     {
 	child = (GtkSheetChild *)children->data;