Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORS capability #13

Closed
jselsing opened this issue Nov 26, 2018 · 7 comments
Closed

FORS capability #13

jselsing opened this issue Nov 26, 2018 · 7 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@jselsing
Copy link

Hi @fpavogt

I can see that FORS I currently not supported. What would be required to it to make it work? Would it be something that a user could almost trivially, or does it require specific knowledge of the instrument?

@JohnPritchard
Copy link

JohnPritchard commented Nov 26, 2018 via email

@jselsing
Copy link
Author

Hi @JohnPritchard

I mean FORS2. FORS1 was decommissioned in 2009, right?

@JohnPritchard
Copy link

JohnPritchard commented Nov 26, 2018 via email

@jselsing
Copy link
Author

Wow, @JohnPritchard. It looks like it is working beautifully in the P2 interface.

Do you have a timeline for a PR to the fcmaker repo, so that it can be incorporated into local pipelines?

@JohnPritchard
Copy link

JohnPritchard commented Nov 26, 2018 via email

@fpavogt
Copy link
Owner

fpavogt commented Dec 3, 2018

Hi @jselsing

To answer your initial question: what makes FORS difficult to include in fcmaker is the abundance of modes it offers. Not being a FORS user myself, I decided to stay clear of it for now. In principle, if you are interested in a single, specific mode, it would not be too hard (but not too easy either...) for you to add it to fcmaker.

Evidently, since @JohnPritchard already implemented a full support for all the modes, this would be redundant work. I'm not part of the "eso_fcmaker" developments inside p2. But from what @JohnPritchard says, your best bet might be to hope/wait for a dedicated p2api.generateFindingChart() function to be offered officially by ESO.

@fpavogt fpavogt added the enhancement New feature or request label Dec 3, 2018
@fpavogt fpavogt added the wontfix This will not be worked on label Dec 22, 2018
@fpavogt fpavogt closed this as completed Dec 22, 2018
@fpavogt
Copy link
Owner

fpavogt commented Dec 22, 2018

Since eso_fcmaker (now called p2fc) is officially out, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants